[netsa-tools-discuss] Compilation error with SiLK 3.17.0

[Mark Thomas]

Bo-

Thank you for bringing this bug to my attention.

I am able to compile SiLK on RedHat EL7 (gcc 4.8.5 20150623), but I
get the same error as you on RedHat EL6 (gcc 4.4.7 20120313).

The attached patch fixes the issue.  Apply with

  patch -p1 < rwstatssetup.c.patch

A new release with this change (and additional changes to quiet
warnings from the older version of gcc) will be available today or
tomorrow.

Thanks again,

-Mark


-----Original Message-----
From: Bo Bayles <bbayles at obsrvbl.com>
Date: Sat, 21 Apr 2018 22:03:56 -0500
To: <netsa-tools-discuss at cert.org>
Subject: [netsa-tools-discuss] Compilation error with SiLK 3.17.0

I found that I get a compilation error when building SiLK 3.17.0 on
CentOS 6 that I didn't get with 3.16.1.

Specifically the error is:

    Making all in rwstats
    make[3]: Entering directory `/netsa-pkg/silk-src/src/rwstats'
    depbase=`echo rwstatssetup.o | sed 's|[^/]*$|.deps/&|;s|\.o$||'`;\
        gcc    -I. -I../../src/include -I../../src/include  -DNDEBUG
-D_ALL_SOURCE=1 -D_GNU_SOURCE=1   -Wall -W -Wmissing-prototypes
-Wformat=2 -Wdeclaration-after-statement -Wpointer-arith
-fno-strict-aliasing -O3  -MT rwstatssetup.o -MD -MP -MF $depbase.Tpo
-c -o rwstatssetup.o rwstatssetup.c &&\
        mv -f $depbase.Tpo $depbase.Po
    rwstatssetup.c:97: error: redefinition of typedef 'builtin_field_t'
    rwstats.h:67: note: previous declaration of 'builtin_field_t' was here
    make[3]: *** [rwstatssetup.o] Error 1
    make[3]: Leaving directory `/netsa-pkg/silk-src/src/rwstats'
    make[2]: Leaving directory `/netsa-pkg/silk-src/src'
    make[2]: *** [all-recursive] Error 1
    make[1]: Leaving directory `/netsa-pkg/silk-src'
    make[1]: *** [all-recursive] Error 1
    make: *** [silk] Error 2

I notice that this is something that changed in the new version:
https://github.com/bbayles/netsa-pkg/blob/090f127375f0b29ffbc000da29c6c1e5243036e2/silk-src/src/rwstats/rwstatssetup.c#L82-L97

I've not figured out why building on Debian still works, but I wonder
if this might be fixed? The RHEL 6 family will be around for a while,
I'm afraid.

Best regards,

-Bo

-------------- next part --------------
A non-text attachment was scrubbed...
Name: rwstatssetup.c.patch
Type: text/x-patch
Size: 989 bytes
Desc: not available
URL: <http://lists.sei.cmu.edu/pipermail/netsa-tools-discuss/attachments/20180423/795f2a2f/attachment.bin>